MDEV-39772 SET GLOBAL innodb_log_archive=OFF breaks recovery#5305
Conversation
log_t::set_recovered(): Set circular_recovery_from_sequence_bit_0 if the log was recovered in the innodb_log_archive=ON format, so that a subsequent SET GLOBAL innodb_log_archive=OFF will properly wait for a checkpoint before changing the format.
|
|
There was a problem hiding this comment.
Code Review
This pull request updates InnoDB's recovery logic in log0recv.cc by adjusting the circular_recovery_from_sequence_bit_0 condition to account for when innodb_log_archive is enabled. It also adds and refines corresponding test cases in the blob-crash and log_archive test suites to validate log archiving behavior during crashes and restarts. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Description
MDEV-39772:
SET GLOBAL innodb_log_archive=OFFbreaks recoverylog_t::set_recovered(): Setcircular_recovery_from_sequence_bit_0if the log was recovered in theinnodb_log_archive=ONformat, so that a subsequentSET GLOBAL innodb_log_archive=OFFwill properly wait for a checkpoint before changing the format.This fixes up #4405.
How can this PR be tested?
The
innodb_page_size=4kandinnodb_page_size=8kvariants of that test would fail when the fix is absent.