Skip to content

MDEV-39772 SET GLOBAL innodb_log_archive=OFF breaks recovery#5305

Merged
dr-m merged 1 commit into
13.0from
MDEV-39772
Jun 30, 2026
Merged

MDEV-39772 SET GLOBAL innodb_log_archive=OFF breaks recovery#5305
dr-m merged 1 commit into
13.0from
MDEV-39772

Conversation

@dr-m

@dr-m dr-m commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

MDEV-39772: SET GLOBAL innodb_log_archive=OFF breaks recovery

log_t::set_recovered(): Set circular_recovery_from_sequence_bit_0 if the log was recovered in the innodb_log_archive=ON format, so that a subsequent SET GLOBAL innodb_log_archive=OFF will properly wait for a checkpoint before changing the format.

This fixes up #4405.

How can this PR be tested?

mysql-test/mtr --parallel=auto innodb.blob-crash

The innodb_page_size=4k and innodb_page_size=8k variants of that test would fail when the fix is absent.

log_t::set_recovered(): Set circular_recovery_from_sequence_bit_0
if the log was recovered in the innodb_log_archive=ON format,
so that a subsequent SET GLOBAL innodb_log_archive=OFF will
properly wait for a checkpoint before changing the format.
@dr-m dr-m requested a review from Thirunarayanan June 30, 2026 09:00
@dr-m dr-m self-assigned this Jun 30, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates InnoDB's recovery logic in log0recv.cc by adjusting the circular_recovery_from_sequence_bit_0 condition to account for when innodb_log_archive is enabled. It also adds and refines corresponding test cases in the blob-crash and log_archive test suites to validate log archiving behavior during crashes and restarts. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@dr-m dr-m merged commit 1812a45 into 13.0 Jun 30, 2026
16 of 19 checks passed
@dr-m dr-m deleted the MDEV-39772 branch June 30, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants