refactor(generator): migrate typesystem parser to QXmlStreamReader#322
Merged
usiems merged 2 commits intoMeVisLab:mainfrom Oct 28, 2025
Merged
Conversation
mrbean-bremen
approved these changes
Oct 27, 2025
jcfr
force-pushed
the
migrate-generator-to-qxmlstreamreader
branch
from
25fdb58 to
3175b47
Compare
usiems
reviewed
Oct 27, 2025
Contributor
usiems
left a comment
usiems
left a comment
There was a problem hiding this comment.
What about the dependency on QtCore5Compat in generator/generator.pri? Can this dependency finally be removed with this change?
Contributor
|
I meant it would be nice if you removed the dependency on QtCore5Compat in this merge request if this was the last code that needed it. |
- drop the legacy QtXml reader/handler stack in favor of `QXmlStreamReader` - rewrite the typesystem Handler to drive the stream reader directly and wrap `QXmlStreamAttributes` - update attribute helpers and error reporting to match the new streaming API - open typesystem files with QText mode and surface parse failures via `ReportHandler`
…r.pri Suggested-by: Uwe Siems <[email protected]>
jcfr
force-pushed
the
migrate-generator-to-qxmlstreamreader
branch
from
3175b47 to
9b39d41
Compare
usiems
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QXmlStreamReaderQXmlStreamAttributesReportHandler