fix(config-tables): expand untitled $ref targets in the value type - #12259
Open
JulianMaurin wants to merge 1 commit into
Open
fix(config-tables): expand untitled $ref targets in the value type#12259JulianMaurin wants to merge 1 commit into
JulianMaurin wants to merge 1 commit into
Conversation
An option whose schema property is a bare `$ref` to an untitled `$defs`
entry rendered an empty value type, since both renderers only read the
target's `title`. Expand the target instead, and name the keys of an
inline object shape so a union like `batch_size` reads as
"integer or `{min, max}`".
MRGFY-8297
Change-Id: I25ebe90e607c8227ad921b9fe9d8305801e1ef4f
Contributor
Merge Protections🔴 2 of 6 protections blocking · waiting on 👀 reviews
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 4 satisfied protections🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Pull request overview
Fixes config option value-type rendering when a schema property is a bare $ref to an untitled $defs entry by expanding the referenced target instead of relying on the target’s title (which can be empty). This improves both the React-rendered config tables and the markdown/plain-text renderer used for exports/tests.
Changes:
- Expand untitled
$reftargets ingetValueTypeText()(markdown/plain-text) to avoid empty value-type cells. - Expand untitled
$reftargets ingetValueType()(React) to avoid rendering an empty type label. - Render inline object shapes as
{key1, key2}(instead of justobject) so unions likeinteger or {min, max}are clearer; adds test coverage for both renderers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util/schemaToMarkdown.ts | Expands untitled $ref targets and renders inline object shapes as a {keys} summary in the plain-text/markdown renderer. |
| src/components/Tables/ConfigOptions.tsx | Expands untitled $ref targets and renders inline object shapes as {keys} in the React config options table renderer. |
| src/components/Tables/ConfigOptions.test.tsx | Adds regression tests covering untitled $ref expansion and inline object key rendering for both renderers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JulianMaurin
marked this pull request as ready for review
July 29, 2026 15:09
JulianMaurin
commented
Jul 29, 2026
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An option whose schema property is a bare
$refto an untitled$defsentry rendered an empty value type, since both renderers only read the
target's
title. Expand the target instead, and name the keys of aninline object shape so a union like
batch_sizereads as"integer or
{min, max}".MRGFY-8297