-
-
Notifications
You must be signed in to change notification settings - Fork 255
chore: add MegaETH Testnet v2
#7272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for MegaETH Testnet v2 as a custom network and migrates Monad Testnet from a custom network to an Infura-supported network. The changes update network type definitions, chain IDs, RPC endpoints, block explorers, and corresponding test snapshots.
- Adds
megaeth-testnet-v2toCustomNetworkTypewith chain ID0x18c7and deprecates the originalmegaeth-testnet - Moves
monad-testnetfromCustomNetworkTypetoInfuraNetworkTypewith chain ID0x279f - Updates test snapshots to reflect the new Monad Testnet Infura network configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/controller-utils/src/types.ts | Adds monad-testnet to InfuraNetworkType, adds megaeth-testnet-v2 to CustomNetworkType with deprecation notices, and updates related enums (BuiltInNetworkName, ChainId, NetworksTicker, BlockExplorerUrl, NetworkNickname) |
| packages/controller-utils/src/constants.ts | Adds RPC endpoint for megaeth-testnet-v2 and ticker symbol, updates BUILT_IN_NETWORKS configuration |
| packages/controller-utils/CHANGELOG.md | Documents addition of monad-testnet to InfuraNetworkType |
| packages/network-controller/tests/NetworkController.test.ts | Updates test snapshots to include Monad Testnet as an Infura network with expected configuration |
| packages/assets-controllers/src/TokenDetectionController.test.ts | Adds Monad Testnet chain ID to token detection test expectations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@metamaskbot publish preview |
|
@metamaskbot publish preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
| * @deprecated Please use `megaeth-testnet-v2` instead. | ||
| */ | ||
| 'megaeth-testnet': 'https://carrot.megaeth.com/rpc', | ||
| 'megaeth-testnet-v2': 'https://timothy.megaeth.com/rpc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stanleyyconsensys Is there any reason we wouldn’t simply update the previous one? Or were you concerned this might introduce a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM, I see now that this isn’t the only change; the chainId is also being updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it is kind of a new network,
+
we try to avoid controller-utils breaking change, as it will introduce breaking change for many controllers
and soon we will introduce a new controller to store the information remotely
Explanation
Due to the deprecation of MegaETH testnet v1 (chainId 0x18c6)
This PR Adds MegaETH Testnet V2 (chainId 0x18c7) across constants/types and default custom networks.
Add
megaeth-testnet-v2to controller-utils constants/types:Include
megaeth-testnet-v2in NetworkController:References
Checklist
Note
Adds MegaETH Testnet v2 (chainId 0x18c7) across controller-utils and as a default custom network in network-controller.
megaeth-testnet-v2support:BuiltInNetworkName,ChainId(0x18c7),NetworksTicker,BlockExplorerUrl,NetworkNickname.BUILT_IN_NETWORKSwith RPC prefs and inBUILT_IN_CUSTOM_NETWORKS_RPC(https://timothy.megaeth.com/rpc).TESTNET_TICKER_SYMBOLS.megaeth-testnet-v2in default custom networks (getDefaultCustomNetworkConfigurationsByChainId).AdditionalDefaultNetworktype to includemegaeth-testnet-v2.Written by Cursor Bugbot for commit 5dcbfa3. This will update automatically on new commits. Configure here.