Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/eth-json-rpc-middleware/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Include `WalletContext` in EIP-7715 requests ([#7331](https://github.com/MetaMask/core/pull/7331))

## [22.0.0]

### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,14 @@ describe('wallet_requestExecutionPermissions', () => {
let request: JsonRpcRequest;
let params: RequestExecutionPermissionsRequestParams;
let processRequestExecutionPermissionsMock: jest.MockedFunction<ProcessRequestExecutionPermissionsHook>;
let context: WalletMiddlewareParams['context'];

const callMethod = async () => {
const handler = createWalletRequestExecutionPermissionsHandler({
processRequestExecutionPermissions:
processRequestExecutionPermissionsMock,
});
return handler({ request } as WalletMiddlewareParams);
return handler({ request, context } as WalletMiddlewareParams);
};

beforeEach(() => {
Expand All @@ -83,6 +84,10 @@ describe('wallet_requestExecutionPermissions', () => {
request = klona(REQUEST_MOCK);
params = request.params as RequestExecutionPermissionsRequestParams;

context = new Map([
['origin', 'test-origin'],
]) as WalletMiddlewareParams['context'];

processRequestExecutionPermissionsMock = jest.fn();
processRequestExecutionPermissionsMock.mockResolvedValue(RESULT_MOCK);
});
Expand All @@ -92,6 +97,7 @@ describe('wallet_requestExecutionPermissions', () => {
expect(processRequestExecutionPermissionsMock).toHaveBeenCalledWith(
params,
request,
context,
);
});

Expand All @@ -108,6 +114,7 @@ describe('wallet_requestExecutionPermissions', () => {
expect(processRequestExecutionPermissionsMock).toHaveBeenCalledWith(
params,
request,
context,
);
});

Expand All @@ -119,6 +126,7 @@ describe('wallet_requestExecutionPermissions', () => {
expect(processRequestExecutionPermissionsMock).toHaveBeenCalledWith(
params,
request,
context,
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export type RequestExecutionPermissionsResult = Json &
export type ProcessRequestExecutionPermissionsHook = (
request: RequestExecutionPermissionsRequestParams,
req: JsonRpcRequest,
context: WalletMiddlewareContext,
) => Promise<RequestExecutionPermissionsResult>;

/**
Expand All @@ -76,7 +77,7 @@ export function createWalletRequestExecutionPermissionsHandler({
}: {
processRequestExecutionPermissions?: ProcessRequestExecutionPermissionsHook;
}): JsonRpcMiddleware<JsonRpcRequest, Json, WalletMiddlewareContext> {
return async ({ request }) => {
return async ({ request, context }) => {
if (!processRequestExecutionPermissions) {
throw rpcErrors.methodNotSupported(
'wallet_requestExecutionPermissions - no middleware configured',
Expand All @@ -87,6 +88,6 @@ export function createWalletRequestExecutionPermissionsHandler({

validateParams(params, RequestExecutionPermissionsStruct);

return await processRequestExecutionPermissions(params, request);
return await processRequestExecutionPermissions(params, request, context);
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ describe('wallet_revokeExecutionPermission', () => {
let request: JsonRpcRequest<RevokeExecutionPermissionRequestParams>;
let params: RevokeExecutionPermissionRequestParams;
let processRevokeExecutionPermissionMock: jest.MockedFunction<ProcessRevokeExecutionPermissionHook>;
let context: WalletMiddlewareParams['context'];

const callMethod = async () => {
const handler = createWalletRevokeExecutionPermissionHandler({
processRevokeExecutionPermission: processRevokeExecutionPermissionMock,
});
return handler({ request } as WalletMiddlewareParams);
return handler({ request, context } as WalletMiddlewareParams);
};

beforeEach(() => {
Expand All @@ -34,6 +35,10 @@ describe('wallet_revokeExecutionPermission', () => {
request = klona(REQUEST_MOCK);
params = request.params as RevokeExecutionPermissionRequestParams;

context = new Map([
['origin', 'test-origin'],
]) as WalletMiddlewareParams['context'];

processRevokeExecutionPermissionMock = jest.fn();
processRevokeExecutionPermissionMock.mockResolvedValue({});
});
Expand All @@ -43,6 +48,7 @@ describe('wallet_revokeExecutionPermission', () => {
expect(processRevokeExecutionPermissionMock).toHaveBeenCalledWith(
params,
request,
context,
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export type RevokeExecutionPermissionRequestParams = Infer<
export type ProcessRevokeExecutionPermissionHook = (
request: RevokeExecutionPermissionRequestParams,
req: JsonRpcRequest,
context: WalletMiddlewareContext,
) => Promise<RevokeExecutionPermissionResult>;

/**
Expand All @@ -41,7 +42,7 @@ export function createWalletRevokeExecutionPermissionHandler({
}: {
processRevokeExecutionPermission?: ProcessRevokeExecutionPermissionHook;
}): JsonRpcMiddleware<JsonRpcRequest, Json, WalletMiddlewareContext> {
return async ({ request }) => {
return async ({ request, context }) => {
if (!processRevokeExecutionPermission) {
throw rpcErrors.methodNotSupported(
'wallet_revokeExecutionPermission - no middleware configured',
Expand All @@ -52,6 +53,6 @@ export function createWalletRevokeExecutionPermissionHandler({

validateParams(params, RevokeExecutionPermissionRequestParamsStruct);

return await processRevokeExecutionPermission(params, request);
return await processRevokeExecutionPermission(params, request, context);
};
}
Loading