feat: add :createMultichainAccountGroups action to batch account creation #7801
Draft
ccharly wants to merge 11 commits intohm/bip-44-perf-and-devx-improvementsfrom
Draft
feat: add :createMultichainAccountGroups action to batch account creation #7801ccharly wants to merge 11 commits intohm/bip-44-perf-and-devx-improvementsfrom
:createMultichainAccountGroups action to batch account creation #7801ccharly wants to merge 11 commits intohm/bip-44-perf-and-devx-improvementsfrom
Conversation
hmalik88
reviewed
Feb 2, 2026
Comment on lines
+230
to
+233
| const account = this.messenger.call( | ||
| 'AccountsController:getAccount', | ||
| accountId, | ||
| ); |
Contributor
There was a problem hiding this comment.
I think we can avoid these n number of controller calls. We can push the accountId into an array and just call AccountsController:getAccounts after the loop is finished and then do the assertions looping through the returned array.
Contributor
Author
There was a problem hiding this comment.
Yup that's right, I forgot about the new :getAccounts 🙈 thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
TODO
References
N/A
Checklist