feat: add rwa data to tokens in tokens controller#7804
Merged
oscarwroche merged 11 commits intomainfrom Feb 5, 2026
Merged
Conversation
oscarwroche
force-pushed
the
feat/sync-rwa-data-tokens-controller
branch
2 times, most recently
from
71c41ef to
b0f194e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
oscarwroche
force-pushed
the
feat/sync-rwa-data-tokens-controller
branch
2 times, most recently
from
9a7d42f to
7cf3066
Compare
oscarwroche
changed the title
oscarwroche
force-pushed
the
feat/sync-rwa-data-tokens-controller
branch
from
bd29fa0 to
994090c
Compare
mcmire
reviewed
Feb 2, 2026
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One suggestion. Would be good to get input from @MetaMask/metamask-assets as well.
BTW, cp-XXX in PR titles for this repo doesn't have any effect — this pattern is only applicable to extension and mobile.
| // We rely on `window` to make requests | ||
| testEnvironment: '<rootDir>/jest.environment.js', | ||
|
|
||
| // Watchman isn't available in some environments (e.g. sandboxed CI/containers) |
Contributor
There was a problem hiding this comment.
Nit: Should this be in its own PR? It doesn't seem to be related to the changes here and might get buried. It would also be good to understand what you were doing when you encountered the problem that this fixes.
Contributor
Author
There was a problem hiding this comment.
It's just codex that added this, good catch, will get rid of it :)
Contributor
Author
We would like to release a version of this package with these changes to cherry pick for last week's RC - do you know what the usual method for this would be ? @mcmire |
Contributor
|
@oscarwroche Yup! So the process works like this:
|
Contributor
|
@oscarwroche i'll publish a preview build , can you pls use it on the extension and check if everything is working as expected |
Contributor
|
@metamaskbot publish-preview |
Akaryatrh
changed the title
Akaryatrh
requested changes
Feb 4, 2026
Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@gmail.com>
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Akaryatrh
approved these changes
Feb 5, 2026
Prithpal-Sooriya
approved these changes
Feb 5, 2026
salimtb
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
rwaDataonto tokens when metadata is updated.rwaDatathroughaddTokenso suggested assets can carry RWA data.rwaDatafrom the supplied argument instead of token metadata (which doesn't containrwaData)References
Checklist
Note
Medium Risk
Touches token state write paths (
addToken/watchAsset) and cache-to-state propagation, which can affect persisted token metadata and UI display ifrwaDatais set/cleared incorrectly, but scope is limited and covered by new tests.Overview
Adds optional
rwaDataplumbing toTokensControllertoken additions sowatchAsset/addTokencan persist RWA metadata, including allowingrwaData: undefinedto clear previously-stored RWA data on re-add.Also updates the TokenListController cache sync logic to key lookups by lowercased token address and to propagate cached
rwaDataonto existing tokens, with tests covering overwrite/clear behavior and cache-driven updates; changelog is updated accordingly.Written by Cursor Bugbot for commit cea397b. This will update automatically on new commits. Configure here.