Skip to content

Mikesposito/refactor/simplify controller#7809

Open
wantedsystem wants to merge 7 commits intofeat/add-config-registry-controllerfrom
mikesposito/refactor/simplify-controller
Open

Mikesposito/refactor/simplify controller#7809
wantedsystem wants to merge 7 commits intofeat/add-config-registry-controllerfrom
mikesposito/refactor/simplify-controller

Conversation

@wantedsystem
Copy link
Contributor

@wantedsystem wantedsystem commented Feb 2, 2026

Explanation

Refactor / simplify config registry controller

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes controller state shape and polling/stop APIs, which can break consumers relying on fetchError, filtered network storage, or token-based stop behavior. Network selection semantics also change (filtering moved to selectors; duplicate chainId handling now last-write-wins).

Overview
Simplifies ConfigRegistryController by removing fetchError and the NetworkConfigEntry wrapper, storing raw RegistryNetworkConfig objects keyed by chainId.

Moves network filtering from fetch-time to consumption-time by adding selectNetworks and selectFeaturedNetworks (with reselect), and updates behavior to store all API networks while featured/active/non-testnet filtering is applied via selectors. Duplicate chainId resolution is simplified to last-write-wins and the warning/priority logic is removed.

Polling/stop behavior is streamlined: the messenger stopPolling action now stops all polling sessions (no token), delayed/placeholder-token logic is removed, and error handling now only reports via captureException without mutating state/fallback bookkeeping. Tests, build config (exclude test-helpers.ts), and changelog are updated accordingly.

Written by Cursor Bugbot for commit fd924fb. This will update automatically on new commits. Configure here.

@wantedsystem wantedsystem requested a review from a team as a code owner February 2, 2026 13:48
@mikesposito mikesposito changed the base branch from main to feat/add-config-registry-controller February 2, 2026 18:17
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants