perf: add Node.js memory optimization for ESLint CI#7815
Draft
cryptodev-2s wants to merge 5 commits intomainfrom
Draft
perf: add Node.js memory optimization for ESLint CI#7815cryptodev-2s wants to merge 5 commits intomainfrom
cryptodev-2s wants to merge 5 commits intomainfrom
Conversation
09f1f62 to
9a22e60
Compare
Disable expensive rules that provide limited value: - prettier/prettier (~30% savings) - Prettier runs separately via lint:misc - import-x/namespace (~22% savings) - Very expensive with limited benefit Add NODE_OPTIONS=--max-semi-space-size=256 to CI lint step as recommended by typescript-eslint for better memory management. See: https://typescript-eslint.io/troubleshooting/typed-linting/performance
Add NODE_OPTIONS='--max-semi-space-size=256' to improve GC performance during typed linting in large monorepos. See: https://typescript-eslint.io/troubleshooting/typed-linting/performance
0fb3ce3 to
64497c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
NODE_OPTIONS='--max-semi-space-size=256'to the lint job to improve GC performance during typed lintingCI lint job is failing with out-of-memory errors during ESLint's typed linting phase. This is the recommended first optimization from the typescript-eslint performance guide.
References
https://typescript-eslint.io/troubleshooting/typed-linting/performance
Checklist