feat: pass required assets to transaction controller#7819
Open
matthewwalsh0 wants to merge 5 commits intomainfrom
Open
feat: pass required assets to transaction controller#7819matthewwalsh0 wants to merge 5 commits intomainfrom
matthewwalsh0 wants to merge 5 commits intomainfrom
Conversation
matthewwalsh0
changed the base branch from
main
to
feat/transaction-required-assets-v2
matthewwalsh0
changed the title
matthewwalsh0
force-pushed
the
feat/transaction-required-assets-v2
branch
from
df20b41 to
439c6cf
Compare
matthewwalsh0
force-pushed
the
feat/eip5792-required-assets
branch
from
7347a53 to
5db5306
Compare
matthewwalsh0
force-pushed
the
feat/transaction-required-assets-v2
branch
2 times, most recently
from
72a8d15 to
be34464
Compare
matthewwalsh0
force-pushed
the
feat/eip5792-required-assets
branch
2 times, most recently
from
eaabcfe to
f365274
Compare
matthewwalsh0
force-pushed
the
feat/eip5792-required-assets
branch
from
f365274 to
f8ac297
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Pass required assets to transaction controller from
wallet_sendCallshandler in EIP-5792 middleware.References
Checklist
Note
Medium Risk
Touches transaction submission plumbing by adding new data to
addTransaction*calls and changing howrequiredAssetsis collected/deduped (including per-call capabilities), which could affect batching behavior if consumers assume prior semantics.Overview
wallet_sendCallsnow forwards EIP-7682auxiliaryFunds.requiredAssetsinto the transaction controller by passing a dedupedrequiredAssetsarray toaddTransaction(single call) andaddTransactionBatch(batch).Validation and deduping were expanded to include
requiredAssetsspecified per-call as well as at the top level (summing duplicate assets by address+standard), and tests/changelog were updated accordingly.Written by Cursor Bugbot for commit c3cd77f. This will update automatically on new commits. Configure here.