chore: read bridge gas fee estimates from gasFeeEstimatesByChainId#7826
Open
chore: read bridge gas fee estimates from gasFeeEstimatesByChainId#7826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Changes the gasFeeEstimates source used in quote metadata calculations to the chain-agnostic
gasFeeEstimatesByChainIdstate. Resulting values will be the same as before but this sets up the clients for removing global selected network referencesSee CHANGELOG for required client changes
Draft extension PR: MetaMask/metamask-extension#37593
References
Checklist
Note
Medium Risk
Touches quote fee/metadata computation and introduces a breaking state shape change for selector consumers; behavior should be equivalent but missing/incorrect chain-scoped gas estimates could change displayed network fees.
Overview
selectBridgeQuotesnow derives EVM gas fee inputs fromgasFeeEstimatesByChainIdkeyed by the quote’ssrcChainId, removing reliance on a global selected-network gas estimate (breaking for consumers that passgasFeeEstimatesintoBridgeAppState).Quote metadata calculation is hardened to handle missing gas estimates (defaults fees to zero), and tests were updated/added to cover the new state shape and the “no gas estimates available” case. Minor follow-ups include using
toHexfor chain-id formatting, switching a few||fallbacks to??, and adjusting some TypeScript generic naming inBridgeControllermetrics tracking.Written by Cursor Bugbot for commit 82d089c. This will update automatically on new commits. Configure here.