Chore/improve error handling #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

lwin-kyaw wants to merge 11 commits into main from chore/improve-error-handling

+713 −131

packages/subscription-controller/CHANGELOG.md

-Original file line number
+Diff line change
@@ Expand Up @@
     ## [Unreleased]
+    ### Added
+    - **BREAKING**: Added two new params, `captureException` and `fetchFunction` to `SubscriptionService` constructor args. ([#7835](https://github.com/MetaMask/core/pull/7835))
+      - `fetchFunction` is to use the client provided `Fetch` API.
+      - `captureException` is to capture the error thrown and report to Sentry.
     ### Changed
+    - Updated `SubscriptionServiceError` to include more information for Sentry reporting. ([#7835](https://github.com/MetaMask/core/pull/7835))
     - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](https://github.com/MetaMask/core/pull/7849))
     - Bump `@metamask/transaction-controller` from `^62.12.0` to `^62.14.0` ([#7802](https://github.com/MetaMask/core/pull/7802), [#7832](https://github.com/MetaMask/core/pull/7832))
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -436,6 +436,23 @@ describe('SubscriptionController', () => { @@
           });
         });
+        it('should surface triggerAccessTokenRefresh errors', async () => {
+          await withController(
+            async ({ controller, mockService, mockPerformSignOut }) => {
+              mockService.getSubscriptions.mockResolvedValue(
+                MOCK_GET_SUBSCRIPTIONS_RESPONSE,
+              );
+              mockPerformSignOut.mockImplementation(() => {
+                throw new Error('Wallet is locked');
+              });
+              await expect(controller.getSubscriptions()).rejects.toThrow(
+                'Wallet is locked',
+              );
+            },
+          );
+        });
         it('should update state when subscription is fetched', async () => {
           const initialSubscription = { ...MOCK_SUBSCRIPTION, id: 'sub_old' };
           const newSubscription = { ...MOCK_SUBSCRIPTION, id: 'sub_new' };
@@ Expand Down @@

Provide feedback