Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
lwin-kyaw
force-pushed
the
chore/improve-error-handling
branch
from
86087f4 to
8ddac2e
Compare
tuna1207
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Current errors from SubscriptionService lack enough context for Sentry, making it hard to diagnose failures. This change enriches SubscriptionServiceError with additional error details (e.g., HTTP status and response info) and improves error handling paths so those details are preserved and surfaced.
References
Related to MetaMask/metamask-extension#39432. This won't fix the underlying issue (which is still TBD) but it adds more helpful info for the debugging.
Checklist
Note
Medium Risk
Moderate risk: changes error wrapping/propagation paths and adds new thrown errors, which can affect downstream error handling and potentially introduce new failure modes during auth refresh or request setup.
Overview
Improves
SubscriptionServiceErrorto carry structured context (causeanddetails) to make Sentry/debugging more actionable.SubscriptionServicenow wraps request failures with request metadata (method/URL) and richer error info, including special handling forHttpError(HTTP status) and non-Errorthrows; auth header acquisition failures are also wrapped similarly.SubscriptionController.triggerAccessTokenRefreshnow catches and rethrows sign-out failures with a clearer message, and tests/changelog are updated to validate these new error surfaces and details.Written by Cursor Bugbot for commit 8ddac2e. This will update automatically on new commits. Configure here.