Draft
Conversation
Complete migration of PerpsController implementation from MetaMask Mobile to enable cross-platform sharing of Perps (Perpetual Futures) functionality. This includes: - PerpsController (~3,000 lines) with full trading functionality - 8 state selectors for UI integration - Comprehensive TypeScript type definitions - 18 utility modules for calculations, formatting, validation - 8 service modules (Trading, MarketData, Eligibility, etc.) - HyperLiquidProvider with full protocol integration - AggregatedPerpsProvider for multi-provider support - Platform services for HyperLiquid client, subscriptions, wallet - Test infrastructure with mocks and 40 unit tests The package uses dependency injection via PerpsPlatformDependencies interface to remain platform-agnostic, allowing Mobile and Extension to provide their own implementations while sharing core business logic.
Add 17 test files migrated from metamask-mobile covering: - Amount conversion, margin, PnL, and position calculations - Order book grouping and order utilities - Market data transformation and sorting - HyperLiquid adapter and validation - TP/SL validation and string parsing utilities Add MIGRATION.md documenting migration status and coverage priorities. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Update @metamask/transaction-controller to ^62.12.0 - Add PR references to CHANGELOG.md - Regenerate yarn.lock Co-Authored-By: Claude Opus 4.5 <[email protected]>
gambinish
changed the title
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Creating a separate branch from #7749 to test preview package publishing via metamask bot. This is just an internal draft, don't worry about reviewing.
References
Checklist