feat(ramps): update payment method delay type to array#7845
Open
georgeweiler wants to merge 4 commits intomainfrom
Open
feat(ramps): update payment method delay type to array#7845georgeweiler wants to merge 4 commits intomainfrom
georgeweiler wants to merge 4 commits intomainfrom
Conversation
amitabh94
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Changes ramp payment method type from string to array to match API response interface.
References
Checklist
Note
Low Risk
Type-only change plus test fixture updates; risk is limited to downstream consumers that still expect
delayto be a string.Overview
Updates the
RampsServicePaymentMethod.delayfield to use a minutes range array (number[]) instead of a human-readable string, matching the API response shape.Updates
getPaymentMethodstest fixtures accordingly and documents the change in theramps-controllerchangelog.Written by Cursor Bugbot for commit 2308b70. This will update automatically on new commits. Configure here.