Skip to content

feat(ramps): update payment method delay type to array#7845

Open
georgeweiler wants to merge 4 commits intomainfrom
ramp-controller-payment-type-update
Open

feat(ramps): update payment method delay type to array#7845
georgeweiler wants to merge 4 commits intomainfrom
ramp-controller-payment-type-update

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Feb 4, 2026

Explanation

Changes ramp payment method type from string to array to match API response interface.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Type-only change plus test fixture updates; risk is limited to downstream consumers that still expect delay to be a string.

Overview
Updates the RampsService PaymentMethod.delay field to use a minutes range array (number[]) instead of a human-readable string, matching the API response shape.

Updates getPaymentMethods test fixtures accordingly and documents the change in the ramps-controller changelog.

Written by Cursor Bugbot for commit 2308b70. This will update automatically on new commits. Configure here.

Cursor Bugbot reviewed your changes and found no issues for commit 2308b70

@georgeweiler georgeweiler requested a review from a team as a code owner February 4, 2026 23:46
@georgeweiler georgeweiler requested a review from a team as a code owner February 4, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants