Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mcmire
reviewed
Apr 10, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4be6409. Configure here.
mcmire
previously approved these changes
Apr 15, 2026
|
|
||
| /** | ||
| * Matches a 0x-prefixed hex string with zero or more hex digits. | ||
| * Unlike `StrictHexStruct` from `@metamask/utils` (which requires at least |
mcmire
dismissed
their stale review
Ah I forgot there is one more pending comment to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new SDK that makes authenticated, bearer-token-backed HTTP calls to user-storage endpoints and adds runtime response validation; correctness depends on API contract and error handling. Changes are additive but touch auth-adjacent data flows and caching behavior via
BaseDataService.Overview
Adds new package
@metamask/authenticated-user-storage, providing anAuthenticatedUserStorageService(aBaseDataService) to call authenticated user-storage API endpoints for delegations (list/create/revoke) and notification preferences (get/put), including bearer-token header support and cache invalidation after mutations.Includes runtime response validation via
@metamask/superstruct, comprehensive nock-based tests/fixtures, and standard package scaffolding (exports, tsconfigs, typedoc, jest config, changelog/license). Repo metadata is updated to include the new package inREADME/dependency graph, TypeScript project references,CODEOWNERS,teams.json, andyarn.lock.Reviewed by Cursor Bugbot for commit aab1ec3. Bugbot is set up for automated code reviews on this repo. Configure here.