Skip to content

feat(keyring-controller): add withKeyringV2 and deprecate withKeyring#8390

Draft
ccharly wants to merge 6 commits intomainfrom
cc/add-withkeyringv2-keyring-controller
Draft

feat(keyring-controller): add withKeyringV2 and deprecate withKeyring#8390
ccharly wants to merge 6 commits intomainfrom
cc/add-withkeyringv2-keyring-controller

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 7, 2026

Explanation

Another approach for withKeyringV2 where we actually extend the existing list of keyring instances to have an optional keyringV2 field.

This allow to keep them in memory and have the same lifecycle than v1 keyring instance (and since all v2 implementations are wrappers for now, they are "bound" to v1 instances anyway).

Original PR:

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@ccharly ccharly force-pushed the cc/add-withkeyringv2-keyring-controller branch from 5a456ff to 41df780 Compare April 7, 2026 13:59
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 7, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​eth-simple-keyring@​11.0.0 ⏵ 11.1.19910010092 +8100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants