feat: Add legacy createOriginMiddleware#8734
Merged
FrederikBolding merged 3 commits intomainfrom May 7, 2026
Merged
Conversation
Mrtenz
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Recently we added
createOriginMiddlewaretov2for usage in the clients. Though using it viaasLegacyMiddlewareintroduces some complications, so for the time being we introduce the same middleware using the legacy API.References
Checklist
Note
Low Risk
Low risk additive change: introduces a new legacy middleware and export without altering existing middleware behavior, with a small chance of conflicts for consumers that already attach an
originfield to requests.Overview
Adds a legacy
createOriginMiddlewarefor@metamask/json-rpc-enginethat mutates the JSON-RPC request object to include anoriginstring (marked deprecated in favor of the v2 API).Exports the new utility from the package entrypoint, updates export snapshot tests, adds a unit test verifying
originis set, and records the addition in the package changelog.Reviewed by Cursor Bugbot for commit 710f931. Bugbot is set up for automated code reviews on this repo. Configure here.