feat(assets-controller): guard BackendWebsocketDataSource chains by feature flag#9647
Open
stanleyyconsensys wants to merge 8 commits into
Open
feat(assets-controller): guard BackendWebsocketDataSource chains by feature flag#9647stanleyyconsensys wants to merge 8 commits into
BackendWebsocketDataSource chains by feature flag#9647stanleyyconsensys wants to merge 8 commits into
Conversation
stanleyyconsensys
temporarily deployed
to
default-branch
July 24, 2026 08:48 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5baa62b. Configure here.
| ); | ||
| return response.fullSupport | ||
| .map(decimalToChainId) | ||
| .filter((chainId) => shouldSupportChain(chainId, remoteFeatureFlags)); |
There was a problem hiding this comment.
WebSocket ignores live flag changes
Medium Severity
BackendWebsocketDataSource now filters active chains with shouldSupportChain and RemoteFeatureFlagController:getState, but unlike AccountsApiDataSource it never subscribes to RemoteFeatureFlagController:stateChange. After a migration flag turns off, the websocket source can keep claiming gated chains until the 20-minute refresh or reconnect, so account-activity ingestion may continue when it should not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5baa62b. Configure here.
Contributor
Author
There was a problem hiding this comment.
will fix in other PR
There was a problem hiding this comment.
Pull request overview
This PR updates @metamask/assets-controller to normalize supported-network chain identifiers into CAIP-2 ChainIds and to gate which supported networks are surfaced as “active chains” for the backend WebSocket data source based on the Snaps → AssetsController migration remote feature flags.
Changes:
- Added a shared
decimalToChainIdutility to normalize numeric/string chain identifiers into CAIP-2ChainIdvalues (with CAIP pass-through). - Updated
BackendWebsocketDataSourceto filter its supported networks viashouldSupportChain(..., remoteFeatureFlags)before surfacing them as active chains. - Added unit tests for chain-id normalization and for migration-stage gating behavior in the WebSocket data source.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/assets-controller/src/utils/index.ts | Exposes the new CAIP/chain-id normalization helper from the utils entrypoint. |
| packages/assets-controller/src/utils/caip.ts | Adds decimalToChainId helper for converting API “decimal” chain identifiers into CAIP-2. |
| packages/assets-controller/src/utils/caip.test.ts | Adds tests for decimal/string conversion and CAIP pass-through. |
| packages/assets-controller/src/data-sources/BackendWebsocketDataSource.ts | Gates active-chain surfacing using migration feature flags and reuses the shared chain-id normalization helper. |
| packages/assets-controller/src/data-sources/BackendWebsocketDataSource.test.ts | Adds coverage for migration gating behavior and chain-id conversion inputs. |
| packages/assets-controller/src/data-sources/AccountsApiDataSource.ts | Removes duplicated helper by importing the shared decimalToChainId. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+357
to
+361
| const { remoteFeatureFlags } = this.#messenger.call( | ||
| 'RemoteFeatureFlagController:getState', | ||
| ); | ||
| return response.fullSupport | ||
| .map(decimalToChainId) |
Contributor
Author
There was a problem hiding this comment.
it is the same for accounts API
| // are always surfaced, while migration networks (Solana, Stellar, Tron) are | ||
| // only surfaced once their per-network stage reaches | ||
| // ReadAssetsControllerWithFallback. | ||
| const { remoteFeatureFlags } = this.#messenger.call( |
Contributor
Author
There was a problem hiding this comment.
out of scope:
if client doesnt register the remote feature flag, the whole fetchActiveChains will be drop, and it impacted to client:
EVM: call RPC as fallback
SNAP: call SNAP as fallback if there is one
| * @param chainIdOrDecimal - Chain ID string (CAIP-2 or decimal) or decimal number. | ||
| * @returns CAIP-2 ChainId. | ||
| */ | ||
| function toChainId(chainIdOrDecimal: number | string): ChainId { |
Contributor
Author
There was a problem hiding this comment.
move to caip.ts for share method
| // HELPER FUNCTIONS | ||
| // ============================================================================ | ||
|
|
||
| function decimalToChainId(decimalChainId: number | string): ChainId { |
Contributor
Author
There was a problem hiding this comment.
move to caip.ts for share method
stanleyyconsensys
changed the title
BackendWebsocketDataSource chains by feature flag
stanleyyconsensys
changed the title
BackendWebsocketDataSource chains by feature flagBackendWebsocketDataSource chains by feature flag
| // PhishingController | ||
| | PhishingControllerBulkScanTokensAction | ||
| // AccountsApiDataSource (Accounts API v6 balances feature flag) | ||
| // AccountsApiDataSource / BackendWebsocketDataSource (Accounts API v6 balances feature flag) |
Contributor
Author
There was a problem hiding this comment.
update doc, it is outdated
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes which chains get websocket subscriptions and active-chain claims during a staged migration; hosts must delegate the new messenger action, but behavior is flag-gated with the same fail-safe as Accounts API.
Overview
Extends the existing Snaps → AssetsController migration gating so
BackendWebsocketDataSourceno longer treats Solana, Stellar, and Tron as active chains until each network’s remote flag reachesReadAssetsControllerWithFallback—matchingAccountsApiDataSource.On supported-network refresh, the websocket data source now reads
RemoteFeatureFlagController:getStateand filtersfullSupportchains withshouldSupportChain. EVM (eip155) chains stay ungated; missing orOffflags keep migration networks on the Snap path.decimalToChainIdis moved into sharedutils/caip.ts(replacing duplicate local helpers).BackendWebsocketDataSourceAllowedActionsandAssetsControllermessenger wiring now requireRemoteFeatureFlagController:getState. Tests cover unset flags and per-namespace independence.Reviewed by Cursor Bugbot for commit e2b065b. Bugbot is set up for automated code reviews on this repo. Configure here.