fix: snap confirmation footer cp-13.13.0 #38601
Open
+54
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +2 -2)
🫰 @MetaMask/core-platform (12 files, +40 -108)
🧪 @MetaMask/qa (1 files, +12 -0)
|
n3ps
commented
Dec 5, 2025
| &__content { | ||
| .snap-ui-renderer__footer { | ||
| @include design-system.screen-sm-min { | ||
| max-width: calc($width-screen-sm-min - 2px); |
Contributor
Author
There was a problem hiding this comment.
- Use container width instead
n3ps
commented
Dec 5, 2025
| backgroundColor={backgroundColor} | ||
| style={{ | ||
| overflowY: 'auto', | ||
| marginBottom: useFooter && hasFooter ? '80px' : '0', |
Contributor
Author
There was a problem hiding this comment.
Let footer position itself within
n3ps
force-pushed
the
n3ps/fix-confirmation-snap
branch
from
1d71d46 to
6f150ce
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
n3ps
force-pushed
the
n3ps/fix-confirmation-snap
branch
2 times, most recently
from
75a8919 to
7250880
Compare
n3ps
force-pushed
the
n3ps/fix-confirmation-snap
branch
from
7250880 to
3d511fc
Compare
Collaborator
Builds ready [3d511fc]
UI Startup Metrics (1230 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
previously approved these changes
Dec 8, 2025
NidhiKJha
previously approved these changes
Dec 8, 2025
FrederikBolding
requested changes
Dec 8, 2025
Member
FrederikBolding
left a comment
FrederikBolding
left a comment
There was a problem hiding this comment.
This PR breaks sticky footers for Snaps confirmations.
- Go to https://metamask.github.io/snaps/test-snaps/3.0.0/
- Install the interactive UI Snap
- Click create dialog
n3ps
force-pushed
the
n3ps/fix-confirmation-snap
branch
from
774ff0d to
daf1c18
Compare
Collaborator
Builds ready [daf1c18]
UI Startup Metrics (1230 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [60ecf9b]
UI Startup Metrics (1271 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
changed the title
Collaborator
Builds ready [6bf3dde]
UI Startup Metrics (1268 ± 85 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3e83bd8]
UI Startup Metrics (1279 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| &__container > &__panel:first-child { | ||
| overflow-y: auto; | ||
| margin: 0; | ||
| padding: 16px; |
Member
There was a problem hiding this comment.
This replaces margin with padding for the content, which we don't want to do: See CSS rule above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the confirmation screen footer layout issue in sidepanel
Changelog
CHANGELOG entry: fix: confirmation footer in sidepanel
Related issues
Fixes:
Manual testing steps
Initiate a Tron or Solana Send transaction
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors Snap UI renderer layout to fix footer and scrolling in sidepanel, updates Snaps routes to RootLayout, and stabilizes E2E pickers by scrolling before interaction.
snap-ui-rendererlayout: make__containerfull-height; move scrolling/padding to first__panel; remove inlinemarginBottomhack and fixed footer positioning inindex.scssandsnap-ui-renderer.js.snapsandsnap-viewstyles to full-height and simplify responsive width logic.margin-bottominline style onsnap-ui-renderer__content.SNAPS_ROUTEandSNAPS_VIEW_ROUTEto useRootLayoutinui/pages/routes/routes.component.tsx.test/e2e/.../snap-interactive-dialog.ts.Written by Cursor Bugbot for commit 3e83bd8. This will update automatically on new commits. Configure here.