test: fix flaky test Multichain API Connect wallet to the multichain dapp#38621
Merged
test: fix flaky test Multichain API Connect wallet to the multichain dapp#38621
Conversation
chloeYue
added
e2e-test
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
requested review from
a team and
jiexi
and removed request for
jiexi
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +23 -2)
|
Collaborator
Builds ready [df9a3f5]
UI Startup Metrics (1229 ± 82 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chloeYue
changed the title
DDDDDanica
previously approved these changes
Dec 8, 2025
Contributor
|
LGTM ! |
pnarayanaswamy
previously approved these changes
Dec 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
…dapp (#38621) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The `getSession()` method in `TestDappMultichain` was flaky in CI, the method used a fixed `driver.delay()` which is unreliable because the element might appear before the JSON content is fully populated, so we have error `SyntaxError: Unexpected end of JSON input`. See failure log: <img width="1447" height="121" alt="Screenshot 2025-12-08 at 10 51 22" src="https://github.com/user-attachments/assets/82fd4dc0-ff00-4db6-804c-acda0e4f8560" /> The fix is to replace the fixed delay with a dynamic conditional wait that checks for valid JSON before parsing. [](https://codespaces.new/MetaMask/metamask-extension/pull/38621?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** Check CI: test should pass and be stable ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Replace fixed delay with a wait-and-parse loop in `getSession()` to return parsed JSON and error if parsing never succeeds. > > - **Tests (E2E)** > - `test/e2e/page-objects/pages/test-dapp-multichain.ts`: > - Update `getSession()` to wait until `#session-method-result-0` contains valid JSON, parse and return it, and throw a descriptive error if parsing never succeeds. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit df9a3f5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
](https://codespaces.new/MetaMask/metamask-extension/pull/38621?quickstart=1){kind=link}
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Builds ready [1f32cc9]
UI Startup Metrics (1266 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
chloeYue
dismissed stale reviews from DDDDDanica, pnarayanaswamy, and adonesky1
via
434fabf
Collaborator
Builds ready [434fabf]
UI Startup Metrics (1258 ± 76 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Unik0rnMaggie
approved these changes
Dec 9, 2025
7 tasks
seaona
approved these changes
Dec 9, 2025
metamaskbot
added
the
release-13.14.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
getSession()method inTestDappMultichainwas flaky in CI, the method used a fixeddriver.delay()which is unreliable because the element might appear before the JSON content is fully populated, so we have errorSyntaxError: Unexpected end of JSON input. See failure log:The fix is to replace the fixed delay with a dynamic conditional wait that checks for valid JSON before parsing.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Check CI: test should pass and be stable
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces a fixed delay with a conditional wait that parses valid JSON before returning in
getSession()to reduce flakiness.test/e2e/page-objects/pages/test-dapp-multichain.ts:getSession()to wait until#session-method-result-0contains valid JSON before parsing, replacingdriver.delay(veryLargeDelayMs).Written by Cursor Bugbot for commit 434fabf. This will update automatically on new commits. Configure here.