Skip to content

Comments

chore!: Remove deprecated UI builders#3859

Merged
FrederikBolding merged 7 commits intomainfrom
fb/remove-deprecated-ui-builders
Feb 20, 2026
Merged

chore!: Remove deprecated UI builders#3859
FrederikBolding merged 7 commits intomainfrom
fb/remove-deprecated-ui-builders

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 17, 2026

We still see Snaps submitted that use the legacy components, they have been deprecated for a long time, so we should remove them from the SDK. This does not break old Snaps that still use these, it just removes the builder functions from the SDK.


Note

Medium Risk
Breaking API removal for any downstream code still importing the legacy builder functions; internal behavior is mostly unchanged but surface-area churn is broad across packages.

Overview
Removes deprecated legacy Snap UI builder helpers from @metamask/snaps-sdk (e.g. panel, text, form, input, button, and the internal createBuilder/component helpers), leaving only the struct/type definitions and NodeType exports for object-based nodes.

Updates consumers and tests across snaps-controllers, snaps-rpc-methods, snaps-simulation, snaps-utils, and snaps-jest to stop using the removed builders and instead pass explicit { type: NodeType.* } node objects (or JSX where supported). Also removes getImageComponent from snaps-sdk/images (tests and implementation), keeping only getImageData.

Written by Cursor Bugbot for commit 85d66d2. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding force-pushed the fb/remove-deprecated-ui-builders branch from 70e5ec1 to 64b625f Compare February 18, 2026 10:18
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (4bff8c7) to head (85d66d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3859      +/-   ##
==========================================
- Coverage   98.58%   98.58%   -0.01%     
==========================================
  Files         428      426       -2     
  Lines       12389    12332      -57     
  Branches     1927     1921       -6     
==========================================
- Hits        12214    12157      -57     
  Misses        175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding force-pushed the fb/remove-deprecated-ui-builders branch from d9d9334 to 85d66d2 Compare February 20, 2026 08:57
@FrederikBolding FrederikBolding marked this pull request as ready for review February 20, 2026 09:20
@FrederikBolding FrederikBolding requested a review from a team as a code owner February 20, 2026 09:20
{
type: NodeType.Text as const,
value:
'Here are some _formatting_ **elements**.\n\nAnd a [link](https://foo.bar).',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should stop supporting markdown when we completely drop the UI builders

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit 5c57821 Feb 20, 2026
130 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-deprecated-ui-builders branch February 20, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants