fix: Unwrap InferMatching type if aliased symbol not found#3863
Merged
Conversation
FrederikBolding
approved these changes
Feb 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3863 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 428 428
Lines 12372 12372
Branches 1922 1922
=======================================
Hits 12197 12197
Misses 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes extraction of documentation for type nodes without an aliased symbol, which seems to be the case for the
DialogParams(possibly because it's a union).The diff in the schema after this change:
Note
Low Risk
Small, localized change to schema generation logic that only affects documentation/metadata extraction, not runtime JSON-RPC behavior.
Overview
Improves
generate-schema.mtsso schema parameter descriptions are correctly extracted from JSDoc when the referenced type has no aliased symbol (falls back to the identifier’s symbol).Adds
unwrapInferMatchingTypeNodeto resolveInferMatching<..., T>wrappers to the underlying type alias before reading JSDoc, fixing missing descriptions for types likeDialogParamsin the generatedschema.json.Written by Cursor Bugbot for commit 8acd542. This will update automatically on new commits. Configure here.