chore!: Remove snap_getCurrencyRate#3866
Merged
FrederikBolding merged 4 commits intomainfrom Feb 20, 2026
Merged
Conversation
Mrtenz
previously approved these changes
Feb 20, 2026
Mrtenz
previously approved these changes
Feb 20, 2026
Mrtenz
approved these changes
Feb 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3866 +/- ##
==========================================
- Coverage 98.58% 98.57% -0.01%
==========================================
Files 426 425 -1
Lines 12332 12311 -21
Branches 1921 1919 -2
==========================================
- Hits 12157 12136 -21
Misses 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
snap_getCurrencyRateas it was an experimental never-documented API used for the BTC Snap.Note
Medium Risk
Breaking API removal that will impact any Snap calling
snap_getCurrencyRateand any consumers relying on the removed SDK types, but changes are largely deletions with minimal logic risk.Overview
Removes the experimental
snap_getCurrencyRateJSON-RPC method end-to-end, including its permitted handler (getCurrencyRate.ts), tests, and registration insnaps-rpc-methods.Updates
snaps-sdktype exports by deleting theget-currency-ratemethod types and removingsnap_getCurrencyRatefrom theSnapMethodsmap, and slightly adjusts Jest coverage thresholds to reflect the deletion.Written by Cursor Bugbot for commit a9928ef. This will update automatically on new commits. Configure here.