Skip to content

Comments

chore!: Remove snap_getCurrencyRate#3866

Merged
FrederikBolding merged 4 commits intomainfrom
fb/drop-get-currency-rate
Feb 20, 2026
Merged

chore!: Remove snap_getCurrencyRate#3866
FrederikBolding merged 4 commits intomainfrom
fb/drop-get-currency-rate

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 20, 2026

Remove snap_getCurrencyRate as it was an experimental never-documented API used for the BTC Snap.


Note

Medium Risk
Breaking API removal that will impact any Snap calling snap_getCurrencyRate and any consumers relying on the removed SDK types, but changes are largely deletions with minimal logic risk.

Overview
Removes the experimental snap_getCurrencyRate JSON-RPC method end-to-end, including its permitted handler (getCurrencyRate.ts), tests, and registration in snaps-rpc-methods.

Updates snaps-sdk type exports by deleting the get-currency-rate method types and removing snap_getCurrencyRate from the SnapMethods map, and slightly adjusts Jest coverage thresholds to reflect the deletion.

Written by Cursor Bugbot for commit a9928ef. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner February 20, 2026 10:13
Mrtenz
Mrtenz previously approved these changes Feb 20, 2026
Mrtenz
Mrtenz previously approved these changes Feb 20, 2026
@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 20, 2026
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (5c57821) to head (a9928ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3866      +/-   ##
==========================================
- Coverage   98.58%   98.57%   -0.01%     
==========================================
  Files         426      425       -1     
  Lines       12332    12311      -21     
  Branches     1921     1919       -2     
==========================================
- Hits        12157    12136      -21     
  Misses        175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit a7453b7 Feb 20, 2026
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/drop-get-currency-rate branch February 20, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants