Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3868 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 425 425
Lines 12311 12311
Branches 1919 1919
=======================================
Hits 12136 12136
Misses 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
080081b to
d355bea
Compare
d355bea to
d77876b
Compare
|
|
||
| /** | ||
| * Cancel a background event created by | ||
| * [`snap_scheduleBackgroundEvent`](https://docs.metamask.io/snaps/reference/snaps-api/snap_schedulebackgroundevent). |
There was a problem hiding this comment.
Are these URLs guaranteed? I worry about them changing and we don't notice in this repo
There was a problem hiding this comment.
Guaranteed in what sense? This is the format of the new URLs based on the schema. They could of course break if we make changes somewhere, but we should set up redirects in that case.
| * - `createAccount` | ||
| * - `updateAccount` | ||
| * - `deleteAccount` | ||
| * - `listAccounts` | ||
| * - `submitResponse` |
There was a problem hiding this comment.
Do you wanna try to deal with improving this more separately as discussed on Slack?
There was a problem hiding this comment.
Yeah, created a separate ticket to figure out unions, and will move the full type for this to the SDK as well.
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
| * that allows for more convenient invocation of Snap methods without needing to | ||
| * specify the full `wallet_snap` parameters. | ||
| * | ||
| * The Snap must be installed and the dapp must have permission to communicate |
There was a problem hiding this comment.
Technically Snaps can call this too, not sure if we need to explain that too much though 😄
This updates documentation for all RPC methods to be more user-facing.
Where possible, I used the already existing documentation on docs.metamask.io, and for more recent methods I wrote some documentation from scratch.
See: https://consensyssoftware.atlassian.net/browse/WPC-443.
Note
Low Risk
Primarily comment/JSDoc and type-documentation changes; the only code-level tweak is a harmless type import/alias removal in
snap_dialog.Overview
Updates documentation across Snaps RPC methods to be more user-facing: adds/expands JSDoc blocks, links to docs.metamask.io, and concrete usage examples for many
snap_*andwallet_*handlers (state, UI interfaces/dialogs, WebSockets, background events, entropy, notifications, etc.).Also refreshes Snaps SDK type docs for method params/results and permission types (mostly wording/clarity like “ID” vs “id”), and aligns
snaps-rpc-methodsdialogto use the exportedDialogResulttype instead of a local alias.Written by Cursor Bugbot for commit 1b743b3. This will update automatically on new commits. Configure here.