Skip to content

Add BNF / META II / TREE-META and update J syntax#5091

Merged
zyv merged 5 commits intoMidnightCommander:masterfrom
jip:add-some-syntax-files
May 9, 2026
Merged

Add BNF / META II / TREE-META and update J syntax#5091
zyv merged 5 commits intoMidnightCommander:masterfrom
jip:add-some-syntax-files

Conversation

@jip
Copy link
Copy Markdown
Contributor

@jip jip commented Apr 10, 2026

Proposed changes

  1. Update syntax highlighting definition for J language.
  2. Add syntax highlighting definition for BNF/EBNF/ABNF/WBNF metasyntax.
  3. Add syntax highlighting definition for META II metasyntax
  4. Add syntax highlighting definition for TREE-META metasyntax.

Checklist

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Notes

  1. I'm the author of original j.syntax added by j.syntax: Please review and add this patch #1491.
  2. Test files and demo screenshots are located in jip/syntax-highlighting/mc.

@github-actions github-actions Bot added this to the Future Releases milestone Apr 10, 2026
@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Apr 10, 2026
@jip jip force-pushed the add-some-syntax-files branch 2 times, most recently from af18c54 to d3c72e8 Compare April 27, 2026 00:41
@zyv zyv changed the title Add some syntax files Add BNF / META II / TREE-META syntax May 9, 2026
@zyv zyv added area: mcedit mcedit, the built-in text editor and removed needs triage Needs triage by maintainers labels May 9, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented May 9, 2026

/rebase

jip added 5 commits May 9, 2026 15:45
Changes to be committed:
	modified:   misc/syntax/j.syntax

Signed-off-by: Igor Zhuravlov <zhuravlov.ip@ya.ru>
Changes to be committed:
	modified:   misc/filehighlight.ini
	modified:   misc/syntax/Makefile.am
	modified:   misc/syntax/Syntax.in
	new file:   misc/syntax/bnf.syntax

Signed-off-by: Igor Zhuravlov <zhuravlov.ip@ya.ru>
Changes to be committed:
	modified:   misc/filehighlight.ini
	modified:   misc/syntax/Makefile.am
	modified:   misc/syntax/Syntax.in
	new file:   misc/syntax/meta-ii.syntax

Signed-off-by: Igor Zhuravlov <zhuravlov.ip@ya.ru>
Changes to be committed:
	modified:   misc/filehighlight.ini
	modified:   misc/syntax/Makefile.am
	modified:   misc/syntax/Syntax.in
	new file:   misc/syntax/tree-meta.syntax

Signed-off-by: Igor Zhuravlov <zhuravlov.ip@ya.ru>
Changes to be committed:
	modified:   misc/syntax/bnf.syntax

Signed-off-by: Igor Zhuravlov <zhuravlov.ip@ya.ru>
@mc-butler mc-butler force-pushed the add-some-syntax-files branch from d3c72e8 to 60ad3ed Compare May 9, 2026 15:45
@zyv zyv changed the title Add BNF / META II / TREE-META syntax Add BNF / META II / TREE-META and update J syntax May 9, 2026
@zyv zyv modified the milestones: Future Releases, 4.9.0 May 9, 2026
@zyv zyv mentioned this pull request May 9, 2026
5 tasks
Copy link
Copy Markdown
Member

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was cautious about looking at the PRs concerning syntax enhancements in view of #5067... However, it will take me a lot of time to get a grip on it no matter the end result. Possibly, we will not be able to get rid of our original restricted highlighter :-/ So, I think it's not right to hold back these PRs until further notice. Especially given the quality of this contribution. Thank you!

@zyv zyv merged commit 10aaab0 into MidnightCommander:master May 9, 2026
10 checks passed
Comment thread misc/filehighlight.ini

[source]
extensions=ada;asm;awk;bash;c;c++;caml;cc;cgi;cpp;cxx;diff;erl;go;h;h++;hh;hi;hpp;hs;inc;jasm;jav;java;js;m4;mak;mjs;ml;mli;mll;mlp;mly;pas;patch;php;phps;pl;pm;prg;py;rb;s;sas;sh;sl;st;swift;tcl;tk;tsx;xq
extensions=ada;asm;awk;bash;bnf;ebnf;c;c++;caml;cc;cgi;cpp;cxx;diff;erl;go;h;h++;hh;hi;hpp;hs;inc;jasm;jav;java;js;m2;m2o;m4;mak;mjs;ml;mli;mll;mlp;mly;pas;patch;php;phps;pl;pm;prg;py;rb;s;sas;sh;sl;st;swift;tcl;tk;tm;tmo;tsx;xq
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is not sorted alphabetically. ebnf must be after diff.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have missed this, sorry. Fixed in f03e97f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

3 participants