Add build statistics to Log Manifest Entry, exact build duration#208
Add build statistics to Log Manifest Entry, exact build duration#208AvdLee wants to merge 14 commits intoMobileNativeFoundation:masterfrom
Conversation
|
cc: @AvdLee I'm likely to pull this into my fork which repairs the function/typecheck timings, since I think this would be quite useful for us |
|
@aleksandergrzyb asked to re-review this. Small changes, just SwiftLint fixes and Sendable support! |
|
@pepicrft IIRC you fixed CI not long ago. Do you have any idea why my CI checks fail while the other recently merged PRs succeed? The DCO check fails due to missing signed commits I think. I can't do the suggested fix, as I'm not the only one that commited to this PR 🤔 |
|
@AvdLee, the macOS and SwiftLint jobs seem legit failures. I'd rebase |
I've updated
LogManifestEntryfor Xcode's latest format, adding statistics like number of warnings and errors. This allows to filter out failed builds without loading.xcactivitylog.I've also changed the build duration from an
Intinto aDoubleand removed the rounding, so build durations are more precise. I believe it's up to the users of the framework to decide to round the build duration instead of us showing wrong build durations from the start.