Conversation
Enables JSON reports to be optionally output directly to stdout for piping to other programs, rather than being written to file system. Log output is suppressed. Involves changing how output directory is handled, but not intended to change existing default functionality in the CLI or the GUI. closes MobilityData#1194
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
|
|
|
Hi @drewda! Thanks for this great contribution and apologies for it slipping our notice in the midst of getting on top of emails after summer vacations. We plan to take a look soon. |
davidgamez
left a comment
There was a problem hiding this comment.
Hi @drewda, great work!
I added a few minor comments that increase the readability of the code. I tested locally and it works as expected.
As a separate thought, I'm thinking of a fatal error scenario. In this case, as expected, the error is flushed to stderr, and nothing is output to stdout. I'm wondering if it makes sense to flush the "content" of the system_errors.json to the stdout so that the pipe processing can make decisions in case of errors. Otherwise, the pipe will get an empty string with no context of the error. This is an edge case where no human is looking at the screen. cc: @emmambd
|
Thank you all for improving and merging this! |
Hi, here's a PR to add some functionality that is useful for developers chaining this together with other tools on the command line. This is related to at least one issue that has requested some aspects of this in the past. This is my first PR ever for this repo, so please do feel free to revise as needed or to hold if it conflicts with other planned functionality. Thanks.
Summary:
Enables JSON reports to be optionally output directly to stdout for piping to other programs, rather than being written to file system. Log output is suppressed. Involves changing how output directory is handled, but not intended to change existing default functionality in the CLI or the GUI.
closes #1194
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anythingscreenshot(s)a shell example showing how this pull request works and fixes the issue(s)