fix(server): respect OPENSHELL_PODMAN_SOCKET env var in embedded driver#1483
Open
russellb wants to merge 1 commit into
Open
fix(server): respect OPENSHELL_PODMAN_SOCKET env var in embedded driver#1483russellb wants to merge 1 commit into
russellb wants to merge 1 commit into
Conversation
The env var was only wired up via clap in the standalone openshell-driver-podman binary. When the Podman driver runs embedded in the gateway, config came exclusively from TOML deserialization and the env var was never consulted. Apply it as a post-deserialization override, matching the existing OPENSHELL_K8S_WORKSPACE_DEFAULT_STORAGE_SIZE pattern. Closes NVIDIA#1446
russellb
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
3 tasks
TaylorMutch
approved these changes
May 20, 2026
Collaborator
|
/ok to test a4c0571 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Podman driver runs embedded in the gateway (the common deployment path),
OPENSHELL_PODMAN_SOCKETwas ignored. The env var was only wired up via clap in the standaloneopenshell-driver-podmanbinary. This applies it as a post-deserialization override in the gateway, matching the existingOPENSHELL_K8S_WORKSPACE_DEFAULT_STORAGE_SIZEpattern.Related Issue
Closes #1446
Changes
OPENSHELL_PODMAN_SOCKETenv var override after TOML config deserialization inbuild_compute_runtime(), consistent with howOPENSHELL_K8S_WORKSPACE_DEFAULT_STORAGE_SIZEis handled for the Kubernetes driverTesting
mise run pre-commitpassescargo test -p openshell-serverpassesChecklist