test(helm): match CA volumes by name#2261
Draft
elezar wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the existing OIDC CA and gateway client CA Helm tests insensitive to unrelated volume insertion. The assertions now identify volumes and mounts by name while preserving coverage of secret names, key mappings, mount paths, and omission behavior.
Related Issue
Related to #1868. This is a generally applicable test cleanup extracted from the HA review.
Changes
containsassertions.ca.crtitem mapping.secret.itemsmust remain absent.notContainschecks for the HTTPS-only omission case.Testing
mise run pre-commitpasses (run insidenix develop)Focused validation:
mise run helm:test— 62 tests passed across 5 suitesmise run helm:lint— defaults and every CI values variant passedChecklist
Notes
PR #2235 also touches these test files for a client CA behavior fix. It does not implement this assertion cleanup, but merge order may require a trivial rebase.