Skip to content

test(helm): match CA volumes by name#2261

Draft
elezar wants to merge 1 commit into
mainfrom
codex/helm-test-named-volumes
Draft

test(helm): match CA volumes by name#2261
elezar wants to merge 1 commit into
mainfrom
codex/helm-test-named-volumes

Conversation

@elezar

@elezar elezar commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

Make the existing OIDC CA and gateway client CA Helm tests insensitive to unrelated volume insertion. The assertions now identify volumes and mounts by name while preserving coverage of secret names, key mappings, mount paths, and omission behavior.

Related Issue

Related to #1868. This is a generally applicable test cleanup extracted from the HA review.

Changes

  • Replace positional OIDC CA volume and volume-mount checks with name-based contains assertions.
  • Replace positional client CA secret checks with exact named-volume assertions, including the ca.crt item mapping.
  • Keep the separate client CA case exact so secret.items must remain absent.
  • Replace the brittle expected volume count with name-based notContains checks for the HTTPS-only omission case.

Testing

  • mise run pre-commit passes (run inside nix develop)
  • Unit tests added/updated
  • E2E tests added/updated (not applicable)

Focused validation:

  • mise run helm:test — 62 tests passed across 5 suites
  • mise run helm:lint — defaults and every CI values variant passed

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; test-only change)

Notes

PR #2235 also touches these test files for a client CA behavior fix. It does not implement this assertion cleanup, but merge order may require a trivial rebase.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant