fix(supervisor): keep instance id stable across reconnects#2263
Draft
elezar wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
SupervisorHello.instance_idstable across reconnect attempts made by one supervisor process. The existing protobuf defines the field as a boot/process epoch, so each new process still receives a fresh UUID while connection retries reuse it.Related Issue
Extracted from #1868 for independent review.
Changes
run_session_loop.run_single_sessionattempt.SupervisorHellowire format unchanged.Testing
mise run pre-commitpassesSIGKILL, not failed assertions. Completed format, license, Helm, Markdown, Python, packaging, and install-script checks passed.nix develop -c cargo test -p openshell-supervisor-process(78 passed, 1 ignored)nix develop -c cargo clippy -p openshell-supervisor-process --all-targets -- -D warningsChecklist