[https://nvbugs/6293015][fix] Add a delegating `@property def vocab_size_padded(self) -> int: return…#15219
Open
tensorrt-cicd wants to merge 1 commit into
Open
[https://nvbugs/6293015][fix] Add a delegating `@property def vocab_size_padded(self) -> int: return…#15219tensorrt-cicd wants to merge 1 commit into
tensorrt-cicd wants to merge 1 commit into
Conversation
…ditionalGeneration The Kimi-K2.5 multimodal wrapper KimiK25ForConditionalGeneration holds the text backbone as self.llm but does not delegate vocab_size_padded to it. When guided_decoding_backend is set (e.g. xgrammar), py_executor_creator.py reads model_engine.model.vocab_size_padded and raises AttributeError. Add a delegating property matching the pattern used by every other VLM wrapper (qwen2vl, qwen3vl, gemma3vl, llava_next, mistral, phi4mm, etc.). Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughKimiK25ForConditionalGeneration now exposes a ChangesVLM wrapper vocabulary size property
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KimiK25ForConditionalGeneration(multimodal wrapper aroundself.llm = DeepseekV3ForCausalLM) does not expose avocab_size_paddedproperty, unlike every other VLM wrapper.@property def vocab_size_padded(self) -> int: return self.llm.vocab_size_paddedtoKimiK25ForConditionalGeneration, matching the pattern inmodeling_qwen2vl.py,modeling_qwen3vl.py, etc.Test plan
Links
Summary by CodeRabbit