Pathfinder: add support on cuQuantum library loading and header descriptors#2376
Open
yangcal wants to merge 8 commits into
Open
Pathfinder: add support on cuQuantum library loading and header descriptors#2376yangcal wants to merge 8 commits into
yangcal wants to merge 8 commits into
Conversation
Contributor
yangcal
commented
Jul 16, 2026
| packaged_with="other", | ||
| linux_sonames=("libcutensornet.so.2",), | ||
| site_packages_linux=("cuquantum/lib",), | ||
| dependencies=("cutensor", "cublas", "cusolver"), |
Contributor
Author
There was a problem hiding this comment.
While cutensornet also has linkage to cublasLt/cusparse/nvJitLink, these are transitive through cublas/cutensor/cusolver and do not need to be explicitly listed here
Contributor
|
/ok to test ae950f8) |
rwgk
approved these changes
Jul 19, 2026
rwgk
left a comment
Contributor
There was a problem hiding this comment.
Awesome!
Findings (gpt-5.6-sol)
No blocking or non-blocking findings were identified. The PR is ready for full CI validation.
Implementation verification
- The local checkout exactly matched the GitHub PR head and had a clean worktree.
- The current official CUDA 12 and
CUDA 13 26.6.0 metapackage and
component wheels were inspected directly. - All five dynamic-library descriptors use the correct
cuquantum/libpaths and
SONAMEs for CUDA 12 and CUDA 13:libcudensitymat.so.0libcupauliprop.so.0libcutensornet.so.2libcustabilizer.so.0libcustatevec.so.1
- The dependency tuples in
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.pymatch the
non-system ELFDT_NEEDEDentries. Unlike cuTENSORMp in PR 2374, none of these
five libraries directly requireslibcudart. - cuPauliProp and cuStabilizer genuinely have no non-system dynamic dependencies,
so their empty Pathfinder dependency tuples are correct. - The cuTensorNet note about
cublasLt,cusparse, andnvJitLinkbeing loaded
transitively through existingcutensor,cublas, andcusolverdescriptors
is accurate. - All five header descriptors use the correct public header basenames and
cuquantum/includepath. Both x86-64 and aarch64 wheel manifests were checked. - The distribution-name regexes match the actual component metadata names for
both-cu12and-cu13packages. - Linux-only support is correct: the current component releases publish Linux
x86-64 and aarch64 wheels, but no Windows wheels. - Although the PyPI project-description text still mentions only three component
packages, the downloadable 26.6.0 metapackage metadata explicitly depends on
all five, including cuPauliProp and cuStabilizer. Therefore the single
cuquantum-cu12/cuquantum-cu13additions are sufficient. - The conda-forge
cuquantummetapackage likewise covers all five components and
uses the expected$CONDA_PREFIX/includeand$CONDA_PREFIX/liblayouts.
Automatic test and CI coverage
- Dynamic-library tests are parameterized from the descriptor catalog through
SUPPORTED_LINUX_SONAMESand therefore include all five new libraries. - Header-discovery tests are parameterized from the header catalog and verify the
exact header basename for each component. - None of the new dynamic libraries has an expected-failure exemption. In strict
mode, either a missing library or a load error fails the test. - Linux wheel CI installs the
test-cu12ortest-cu13dependency group and then
reruns Pathfinder withall_must_workstrictness for libraries and headers. - The pull-request matrix covers CUDA 12.9, CUDA 13.0, and CUDA 13.3 across Linux
x86-64 and aarch64, including both local-toolkit and wheel-only rows. - The changed
cuda_pathfinder/andtoolshed/paths activate the appropriate
full rebuild and test gating.
rwgk
enabled auto-merge (squash)
July 19, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Pathfinder library loading and header discovery support for all five cuQuantum C libraries:
PyPI provides
cuquantum-cu12andcuquantum-cu13metapackages, while conda-forge providescuquantumto install all these sub-components. CUDA 12 and CUDA 13 use the same SONAMEs, headers, andcuquantum/libandcuquantum/includelayouts, so shared descriptors support both variants.Changes
Testing
No dedicated test cases are needed. Existing tests are parameterized from the descriptor catalogs, so new descriptors automatically receive loading, header-discovery, and structural validation coverage. The test-file update only registers component distribution names for installed-wheel detection.