add support for endIndex in node metadata (5.x edition) - #850
Merged
amitguptagwl merged 1 commit intoJul 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
In PR #729, metadata Symbol that contains start index of each node has been added.
My use case requires also getting end index of the node, which has been missing from the initial implementation.
I've added
endIndexproperty to the existing node metadata. This additive improvement does not add much implementation complexity, it is covered by an existingcaptureMetaDataflag.Benchmarks show no measurable performance difference, aside from expected increased memory usage for storing new metadata property when
captureMetaDataflag is enabled.Type
Please mention the type of PR