FreeBSD: Introduce vlan_pcp option for VLAN PCP tagging#520
Draft
rcmcdonald91 wants to merge 1 commit intoNetworkConfiguration:masterfrom
Draft
FreeBSD: Introduce vlan_pcp option for VLAN PCP tagging#520rcmcdonald91 wants to merge 1 commit intoNetworkConfiguration:masterfrom
vlan_pcp option for VLAN PCP tagging#520rcmcdonald91 wants to merge 1 commit intoNetworkConfiguration:masterfrom
Conversation
rcmcdonald91
force-pushed
the
rcm-vlan-pcp
branch
2 times, most recently
from
ad1c3cb to
34631f7
Compare
rcmcdonald91
changed the title
vlan-pcp option for VLAN PCP taggingvlan_pcp option for VLAN PCP tagging
rsmarples
requested changes
Aug 6, 2025
Member
rsmarples
left a comment
rsmarples
left a comment
There was a problem hiding this comment.
Could you add an entry to dhcpcd.conf(5) as well please?
rcmcdonald91
force-pushed
the
rcm-vlan-pcp
branch
from
34631f7 to
c58285c
Compare
rsmarples
reviewed
Aug 11, 2025
| #include <sys/socket.h> | ||
| #include <net/if.h> | ||
| #include <netinet/in.h> | ||
| #include <net/bpf.h> |
Member
There was a problem hiding this comment.
Linux does not have this header, please #ifdef it.... or we could just configure the option regardless of the capability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to achieve feature parity with dhclient(8) in FreeBSD.
https://reviews.freebsd.org/D31263
Still needs documentation.