fix: guard against empty getUserInfo in admin state handler

[fank]

Summary

• getUserInfo returns an empty array ([]) — not nil — when a player has already disconnected, so the isNil guard never triggered
• Replaced isNil check with isEqualTo [] to correctly catch this case
• Removed unused _object variable assignment

Fixes the following error on admin logout:

[OCAP] (recorder) WARNING: getUserInfo returned unexpected data for PID 1580496760: type=ARRAY count=0 data=[]
Error in expression <select 10; ...>
Error Zero divisor
File fnc_eh_onUserAdminStateChanged.sqf, line 32

Test plan

• Have an admin log in and out while server is running — no errors in RPT
• Verify admin UI controls still appear/disappear correctly on login/logout

[gemini-code-assist]

Summary of Changes

Hello @fank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical error occurring during admin logout by refining the onUserAdminStateChanged event handler. The primary change involves updating the conditional check for getUserInfo's return value, ensuring that an empty array, rather than nil, is correctly identified when a player has disconnected. This prevents a "Zero divisor" error and includes a minor cleanup by removing an unused variable.

Highlights

• Admin State Handling: Corrected the logic for handling getUserInfo's return value, switching from an isNil check to isEqualTo [] to properly detect disconnected players.
• Error Resolution: Resolved a "Zero divisor" error that occurred during admin logout, which was caused by incorrect handling of getUserInfo's return.
• Code Cleanup: Removed an unused _object variable assignment, improving code clarity and efficiency.

Changelog

• addons/recorder/fnc_eh_onUserAdminStateChanged.sqf
  • Updated the conditional check for _userInfo from isNil "_userInfo" to _userInfo isEqualTo [].
  • Removed the assignment of the _object variable, as it was unused.

Activity

• No human activity (comments, reviews, or progress updates) has been recorded for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly addresses the issue of getUserInfo returning an empty array instead of nil when a player disconnects, which previously caused a 'Zero divisor' error. The change replaces the isNil check with isEqualTo [] and removes an unused variable, improving the robustness of the admin state handler. The changes align with the stated objective of fixing the error and maintaining code quality.