feat: include config side in :VEHICLE:CREATE: command#82
Conversation
Adds `str side _x` as index [6] to the vehicle creation data sent to the extension. This provides the vehicle's configured faction side (WEST, EAST, GUER, CIV) at creation time, so the extension and web frontend can display correct faction colors for vehicles even when their crew is empty. Previously, vehicle side was only available per-frame in :VEHICLE:STATE: (index 11), and the JSON export hardcoded it as "UNKNOWN" on the entity definition. This caused vehicles to render as black (dead) icons whenever no crew was present.
Summary of ChangesHello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where vehicle side information was missing during creation, causing vehicles to display incorrectly (e.g., as black icons) when their crew was empty. By including the vehicle's faction side in the initial Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully adds the vehicle's side to the :VEHICLE:CREATE: command, which addresses the issue of vehicles appearing with an unknown side when empty in the playback UI. The implementation uses str side _x, which is consistent with the existing logic for units and provides the expected side string (e.g., "WEST", "EAST") to the extension. The change is straightforward and follows the repository's established patterns.
1 participant
Summary
str side _xas index [6] to the_newVehicleDataarray sent via:VEHICLE:CREATE:to the extensionContext
Vehicles in the JSON export had
side: "UNKNOWN"because:VEHICLE:CREATE:never included a side field. The web frontend derived vehicle side from crew members, but when crew was empty the side wasnull, rendering vehicles as black (dead) icons.The per-frame
:VEHICLE:STATE:already sends side at index [10], but the entity-level side was hardcoded to"UNKNOWN"in the extension's export builder since no creation-time side was available.Companion PR
Test plan