Release updates #365
Release updates #365
Conversation
Configure enforcer plugin Configure JReleaser plugin Simplify compiler settings
kittylyst
left a comment
kittylyst
left a comment
There was a problem hiding this comment.
A couple of minor questions about the JDK versions in use, otherwise good.
| uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: zulu | ||
| java-version: 11 |
There was a problem hiding this comment.
Just double-checking, but the plan is that we'll build on JDK 11 with source & target set to 8?
There was a problem hiding this comment.
That is correct, there are 2 artifacts built with release 8: empirism and java8-shim. The rest use release 10 as before.
| </description> | ||
|
|
||
| <properties> | ||
| <maven.compiler.release>10</maven.compiler.release> |
There was a problem hiding this comment.
Why is this 10, rather than 11 as per the strategy clause?
Or is this just a quick fix to get this release out and prove out the pipeline, and this will moved to 11 on the next release?
There was a problem hiding this comment.
It was previously set to 10, I just moved configuration around but didn't change release values as that technically constitutes a bump in major compat. We can review this setting along with dependencies for the next release after the current one to get the CVE fix out the door.
There was a problem hiding this comment.
That's what I thought - thanks for confirming & I think this is GTG. 🚢 in my opinion!
Update build for pushing releases to Sonatype's Maven Central.
Additional updates include: