Support setting certificate permissions for the modern Key Storage Provider#1675
Support setting certificate permissions for the modern Key Storage Provider#1675farhanalam wants to merge 4 commits intoOctopusDeploy:masterfrom
Conversation
Keeping legacy CSP support in place
|
Start Hyponome locally |
| @@ -30,8 +30,8 @@ | |||
| } | |||
| ], | |||
| "LastModifiedOn": "2015-01-30T14:37:16.927+00:00", | |||
There was a problem hiding this comment.
@farhanalam: I would suggest updating this LastModifedOn value
-OR-
I know of at least some templates that do not have a LastModifiedOn value, so removing it might also be an option. @twerthi , @hnrkndrssn?
| "$Meta": { | ||
| "ExportedAt": "2015-01-30T14:39:14.212+00:00", | ||
| "OctopusVersion": "2.6.0.778", | ||
| "Type": "ActionTemplate" |
There was a problem hiding this comment.
@farhanalam: on my past PRs, i have been updating the ExportedAt value, as well as the OctopsVersion. The latter seems reasonably helpful as it identifies which version of Octopus Deploy this update template is known to work with at a minimum.
There was a problem hiding this comment.
Sure I'll be happy to update these values. Does the pull_request_template need to be updated to reflect this change in submission requirements by the Octopus team?
Background
The existing step template only works for the legacy CSP but not the modern KSP on windows machines.
Changes in this PR add support for KSP and keep legacy support in place. The original template fails silently on modern Windows machines.
References:
https://www.gradenegger.eu/en/basics-cryptographic-service-provider-csp-and-key-storage-provider-ksp/
https://stackoverflow.com/questions/65417587/getting-private-keys-to-work-on-windows-7-powershell-version-2
https://stackoverflow.com/questions/66157349/privatekey-is-missing-when-importing-a-certificate
Results
Before
No log changes
After
No log changes
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to it