Fix generated cflags in LLVM/Clang for Star-MC3

[JonatanAntoni]

No description provided.

[JonatanAntoni]

@AlbertHuang-CPU please double check and confirm

[github-actions]

Test Results

  7 files   53 suites   5m 24s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit cb75258.

♻️ This comment has been updated with latest results.

[brondani]

LGTM

[AlbertHuang-CPU]

@AlbertHuang-CPU please double check and confirm

to align with llvm, we need to change Star-MC3 to be "star-mc3".
and I need more time to check other flags.

[jkrech]

@AlbertHuang-CPU do you have any updates?

[AlbertHuang-CPU]

I have checked the whole logic producing the flag combinations for star-mc3, and now can confirm no other error exist.
But we need to modify more places to lower case.
I don't have permission to make change on this branch.
@JonatanAntoni Please help to update the 4 "Star-MC3" to "star-mc3". (i.e. 4 of the 5, except the first one)
elseif(CPU STREQUAL "Star-MC3")
set(CLANG_ARCH "armv8.1m.main")
set(CPU_FEATURES "Star-MC3")
if(MVE STREQUAL "NO_MVE")
if(FPU STREQUAL "NO_FPU")
set(CPU_FEATURES "${CPU_FEATURES}+nomve+nofp")
elseif(FPU STREQUAL "SP_FPU")
set(CPU_FEATURES "${CPU_FEATURES}+nomve+nofp.dp")
elseif(FPU STREQUAL "DP_FPU")
set(CPU_FEATURES "${CPU_FEATURES}+nomve")
endif()
elseif(MVE STREQUAL "INT_MVE")
if(FPU STREQUAL "NO_FPU")
set(CPU_FEATURES "${CPU_FEATURES}+nomve.fp+nofp")
elseif(FPU STREQUAL "SP_FPU")
set(CPU_FEATURES "${CPU_FEATURES}+nomve.fp+nofp.dp")
elseif(FPU STREQUAL "DP_FPU")
message(FATAL_ERROR "Error: Star-MC3+nomve.fp is not supported!")
endif()
elseif(MVE STREQUAL "FP_MVE")
if(FPU STREQUAL "NO_FPU")
message(FATAL_ERROR "Error: Star-MC3+nofp is not supported!")
elseif(FPU STREQUAL "SP_FPU")
message(FATAL_ERROR "Error: Star-MC3+nofp.dp is not supported!")
endif()
endif()

[JonatanAntoni]

@AlbertHuang-CPU, you can always add comments and change suggestions to affected lines of code via the review function. I'll update the casing now.

[brondani]

LGTM

[JonatanAntoni]

@AlbertHuang-CPU, would you please finally confirm?

[AlbertHuang-CPU]

@AlbertHuang-CPU, would you please finally confirm?

LGTM

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.37%. Comparing base (cc68f07) to head (cb75258).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   64.47%   64.37%   -0.10%     
==========================================
  Files         145      145              
  Lines       26013    25956      -57     
  Branches    15674    15632      -42     
==========================================
- Hits        16772    16710      -62     
- Misses       7078     7083       +5     
  Partials     2163     2163              

Flag	Coverage Δ
buildmgr-cov	79.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.