Conversation
|
what exactly do you mean with "linter" here? the pre-commit rules as described at https://open-eo.github.io/openeo-python-client/development.html#pre-commit-for-basic-code-quality-checks ? or linting/formating rules in your development environment? |
|
I just ran |
|
FYI: the current pre-commit setup is intended to fixup just changed files and snippets It is known that the whole repo is not yet fully in line with the rules defined there, because there was a lot of pre-existing code when those linting and formatting rules were added. And doing a big bang reformat of the whole repo will probably break all open pull requests and cause a lot of conflicts. So at the moment it's intended to gradually improve the linting/formatting status of the repo, by just fixing things within the scope of each commit (e.g. the "darker" tool allows to just fixup formatting of lines that were touched, instead of doing full file reformatting). |
|
The changes in this PR seem to be pretty small for a full lint. Is this really so problematic? Can also be closed of course. |
|
this PR introduces some changes in code that is auto-generated (openeo/processes.py, tests/internal/processes/test_generator.py), so these have to be fixed in the generator otherwise this is going to be an endless cat and mouse game I'm going to checrrypick the rest to unblock this |
|
Thanks. Maybe it makes sense to ignore files that are autogenerated via config. |
Just running it on master gives those changes, seems master is not clean currently. This complicates other PR such as #859.
Edit: Weird that tests fail after running only the linter.
Edit 2: Tests also fail on master for me...