fix #810: remove restriction on $ref format #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
force-pushed
the
remove-ref-validation
branch
from
5025731 to
996db4e
Compare
ctreatma
force-pushed
the
remove-ref-validation
branch
from
996db4e to
c4e1108
Compare
DrSatyr
reviewed
Dec 31, 2025
| final String baseRef = getBaseRefForType(refType.getName()); | ||
| if (!ref.startsWith(baseRef)) { | ||
| throw new IllegalArgumentException("Invalid ref: " + ref); | ||
| // If the ref doesn't point to something in #/components, |
Collaborator
There was a problem hiding this comment.
So, looks like just removing this validation would not work well. getRefName method is used by resolveRef method. Under the hood it searches referenced objects only in components section and does not consider remote files. So we need to think here about full support of the remote refs, instead of just removing the validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
RefPointerclass to return the full$refvalue for references that are not under#/components/instead of throwing anIllegalArgumentException. This change enablesopenapi-diffto run successfully against specs that use any valid$refformat rather than prescribing one specific approach to defining references.Fixes #810