[csharp] public TokenProvider to make it implementable from consumer projects#22499
Closed
daberni wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
[csharp] public TokenProvider to make it implementable from consumer projects#22499daberni wants to merge 1 commit intoOpenAPITools:masterfrom
daberni wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
6a47cc9 to
9acccba
Compare
Contributor
Author
|
@wing328 it looks like the suggested technical committee members are quite inactive at the moment. What would be the best way to still be able to contribute to these projects when there is no one approving the pull requests? |
Contributor
9acccba to
4175c61
Compare
Contributor
Author
|
You are right, rebased the branch and there are no significant changes remaining 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenProvider.GetAsync()was declared with visibility modifierinternal. This resulted in a generated class which could only be implemented in the same module, although the class itself is declared aspublicmaking it accessible globally.In the use case of providing an SDK where the Token is provided from some external source this would not be supported right now. By declaring
GetAsync()public, anyone can implement its ownTokenProviderand register it in theIServiceCollectionfor automatic dependency lookup.At the same point I cleared up the unclear declaration of a
_tokencollection, which only is used fromRateLimitProvider.RateLimitProvidernow only uses theTokenContainerdirectly, without roundtrip ofTokenProvider._tokens.Any other implementatio nof
TokenProvidercould declare its own list if necessary.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)