[CRYSTAL] object_id method should be a reserved words#22577
[CRYSTAL] object_id method should be a reserved words#22577wing328 merged 22 commits intoOpenAPITools:masterfrom
Conversation
It's not working because it uses #send method which doesn't exist in Crystal See: https://crystal-lang.org/reference/1.18/crystal_for_rubyists/metaprogramming_help.html#differences-between-ruby-and-crystal
75bf481 to
9d4abe3
Compare
|
It's not perfect but with all this patches I can consume Netbox API :
The generated client is here : https://github.com/jbox-web/netbox-extractor/tree/master/vendor/netbox-client.4.4.8 |
|
Also the Pet store sample is a bit light to exercise all the models : for instance no Maybe using a subset of Netbox API / schema (which is a real world example) would help to better test the generator? Merry Christmas! 🎅 |
Fix: - class EnumAttributeValidatorFor_type < EnumAttributeValidator + class EnumAttributeValidatorForType < EnumAttributeValidator
what about updating |
| @@ -1,8 +0,0 @@ | |||
| # {{#lambdaPrefixWithHash}}{{> api_info}}{{/lambdaPrefixWithHash}} | |||
There was a problem hiding this comment.
Don't mind removing travis support (if someone needs it, we can always add it back) but what about adding github workflow for example as a replacement?
There was a problem hiding this comment.
I'll do that in a next PR
I'll give it a look. Thank you! |
Fix #22563
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)