Skip to content

Conversation

@berk-dilek
Copy link

@berk-dilek berk-dilek commented Jan 5, 2026

Potentially fixes - #22624
When a schema has 'type: number' without an explicit 'format: double', the isDouble flag was not being set even though the dataType correctly resolves to Double. This caused Swift6 (and potentially other generators) to incorrectly add ParameterConvertible conformance to number enums.

The fix ensures isDouble is set to true for all number types that are not explicitly float, matching the behavior of the type mapping.

Affected methods:

  • updateModelForNumber (for standalone enum models)
  • updatePropertyForNumber (for inline enum properties)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixed isDouble not being set for type: number without format. This aligns flags with Double type mapping and prevents Swift6 from adding ParameterConvertible to number enums.

  • Bug Fixes
    • Set isDouble=true for non-float number schemas in updateModelForNumber and updatePropertyForNumber.
    • Covers both explicit format: double and no-format cases to keep generator behavior consistent.

Written for commit 349158b. Summary will update on new commits.

When a schema has 'type: number' without an explicit 'format: double',
the isDouble flag was not being set even though the dataType correctly
resolves to Double. This caused Swift6 (and potentially other generators)
to incorrectly add ParameterConvertible conformance to number enums.

The fix ensures isDouble is set to true for all number types that are
not explicitly float, matching the behavior of the type mapping.

Affected methods:
- updateModelForNumber (for standalone enum models)
- updatePropertyForNumber (for inline enum properties)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant