[Core] Fix isDouble flag not being set for 'type: number' without format #22623
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes - #22624
When a schema has 'type: number' without an explicit 'format: double', the isDouble flag was not being set even though the dataType correctly resolves to Double. This caused Swift6 (and potentially other generators) to incorrectly add ParameterConvertible conformance to number enums.
The fix ensures isDouble is set to true for all number types that are not explicitly float, matching the behavior of the type mapping.
Affected methods:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixed isDouble not being set for type: number without format. This aligns flags with Double type mapping and prevents Swift6 from adding ParameterConvertible to number enums.
Written for commit 349158b. Summary will update on new commits.