Skip to content

fix: [JAVA][SPRING] Nullaways warn with JSpecify => add missing annotation to parameter of method toIndentedString #22685

Merged
wing328 merged 3 commits intomasterfrom
pkernevez-22598-Add-nullable-on-toIndentedString
Jan 13, 2026
Merged

fix: [JAVA][SPRING] Nullaways warn with JSpecify => add missing annotation to parameter of method toIndentedString #22685
wing328 merged 3 commits intomasterfrom
pkernevez-22598-Add-nullable-on-toIndentedString

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 13, 2026

based on #22599 with resolved merge conflicts

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add @nullable to the toIndentedString parameter in generated Java Spring models to align with nullability handling and silence static analysis warnings. Updated tests and regenerated samples; no runtime behavior change.

  • Bug Fixes
    • Add {{>nullableAnnotation}} to toIndentedString parameter in JavaSpring/pojo.mustache.
    • Extend SpringCodegenTest to assert the annotated signature.
    • Regenerate affected Spring samples (cloud, http-interface, reactive) to include the change.

Written for commit 20383b7. Summary will update on new commits.

@wing328 wing328 changed the title Pkernevez 22598 add nullable on to indented string fix: [JAVA][SPRING] Nullaways warn with JSpecify => add missing annotation to parameter of method toIndentedString Jan 13, 2026
@wing328 wing328 marked this pull request as ready for review January 13, 2026 04:56
@wing328 wing328 added this to the 7.19.0 milestone Jan 13, 2026
@wing328 wing328 merged commit 848aecc into master Jan 13, 2026
140 checks passed
@wing328 wing328 deleted the pkernevez-22598-Add-nullable-on-toIndentedString branch January 13, 2026 04:56
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1198 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@typat
Copy link

typat commented Jan 20, 2026

Hi there! I'm trying to implement JSpecify using this new logic. Do you have a sample configuration for how to trigger the @Nullable annotations on fields marked nullable: true without using the JsonNullable wrapper?

I've tried setting openApiNullable: false and mapping Nullable to org.jspecify.annotations.Nullable in importMappings, but I'm having trouble getting the annotation to render in the generated Java models.

edit: NVM I realized I had useNullable set to true. There seems to be a specific set of values in order to produce Null annotations, which is fine. I just didnt have it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants