fix(typescript-fetch): ResponseError prototype chain#23010
Open
jehiah wants to merge 2 commits intoOpenAPITools:masterfrom
Open
fix(typescript-fetch): ResponseError prototype chain#23010jehiah wants to merge 2 commits intoOpenAPITools:masterfrom
jehiah wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
a48d6a1 to
c84a42d
Compare
Author
|
cc Typescript Committee Members: @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha @dennisameling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
ResponseErrorinstances are recognized asErrorbut not asResponseErrorwhen caught. This occurs because TypeScript (and Babel/ES5 transpilation) doesn't automatically preserve the prototype chain for classes extendingError, causinginstanceof ResponseErrorto fail.Related: TypeScript wiki on extending Error
Resolution:
Updated the
ResponseError,FetchErrorandRequiredErrorconstructors to explicitly set the prototypePR checklist
master