Makefile.power: allow using power10 instructions#5802
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom May 6, 2026
Merged
Makefile.power: allow using power10 instructions#5802martin-frbg merged 1 commit intoOpenMathLib:developfrom
martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
OpenBLAS uses various power9 and power10 instructions and they fail to build with errors like in OpenMathLib#4793. Just allow the latest ISA, it will generate the same code, but actually allow the binaries to be assembled.
Collaborator
|
Any minimum LLVM version requirement for this ? ISTR the original problem was specific to BSD |
Contributor
Author
|
I'm not sure, it certainly works with LLVM 19 that FreeBSD currently uses, but I think it's more about minimum binutils version, since -Wa is being passed to as. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBLAS uses various power9 and power10 instructions and they fail to build with errors like in #4793. Just allow the latest ISA, it will generate the same code, but actually allow the binaries to be assembled.