NMS-19359: Event config events display gets cut off when label is longer than normal#8222
Merged
Shahbaz-dataq merged 2 commits intorelease-35.xfrom Jan 7, 2026
Merged
NMS-19359: Event config events display gets cut off when label is longer than normal#8222Shahbaz-dataq merged 2 commits intorelease-35.xfrom
Shahbaz-dataq merged 2 commits intorelease-35.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where event configuration labels were getting cut off when they exceeded normal length. The fix removes the white-space: nowrap CSS property from table cells, allowing text to wrap naturally instead of being truncated.
Key changes:
- Removed CSS constraint that prevented text wrapping in event configuration table
- Refactored multiple test cases to use proper Pinia store isolation
- Updated DOMParser mocking strategy in XML validator tests to use class syntax with
vi.stubGlobal
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/components/EventConfigurationDetail/EventConfigEventTable.vue | Removed white-space: nowrap CSS property to allow long event labels to wrap |
| ui/tests/components/EventConfigurationDetail/Dialog/DeleteEventConfigSourceDialog.test.ts | Refactored test to create isolated Pinia instance and local wrapper for null eventConfigSource scenario |
| ui/tests/components/EventConfigurationDetail/Dialog/DeleteEventConfigEventDialog.test.ts | Refactored test to create isolated Pinia instance with proper state initialization for missing IDs scenario |
| ui/tests/components/EventConfiguration/Dialog/DeleteEventConfigSourceDialog.test.ts | Refactored test with complete store state initialization and isolated wrapper for null eventConfigSource test |
| ui/tests/components/EventConfiguration/BasicInformation.test.ts | Enhanced test to properly invalidate form before verifying save behavior |
| ui/tests/components/EventConfiguration/eventConfigXmlValidator.test.ts | Migrated DOMParser mocks from function syntax to class syntax using vi.stubGlobal, added vi.unstubAllGlobals cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External References