Skip to content

editoast: remove exception key from OccurrenceId enum#16256

Open
younesschrifi wants to merge 1 commit intofeatures/train-schedule-exceptionsfrom
yci/removeExceptionKey
Open

editoast: remove exception key from OccurrenceId enum#16256
younesschrifi wants to merge 1 commit intofeatures/train-schedule-exceptionsfrom
yci/removeExceptionKey

Conversation

@younesschrifi
Copy link
Copy Markdown
Contributor

@younesschrifi younesschrifi commented Apr 14, 2026

When the feature branch will be merge, exception_key won't be used anymore !

Note

This PR targets a feature branch.

@younesschrifi younesschrifi requested review from a team as code owners April 14, 2026 21:08
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:api-change area:railway-manager-interface Work on Railway Manager Interface service labels Apr 14, 2026
@younesschrifi younesschrifi changed the base branch from dev to features/train-schedule-exceptions April 14, 2026 21:08
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

@younesschrifi younesschrifi requested review from SharglutDev, Wadjetz and flomonster and removed request for a team, eckter and elise-chin April 14, 2026 21:08
@younesschrifi younesschrifi force-pushed the yci/removeExceptionKey branch from 22a81ca to 80fb1b8 Compare April 14, 2026 23:42
@github-actions github-actions bot removed area:integration-tests Work on Integration test, by nature related to different services area:railway-manager-interface Work on Railway Manager Interface service labels Apr 14, 2026
Copy link
Copy Markdown
Member

@Wadjetz Wadjetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (not tested)

@flomonster
Copy link
Copy Markdown
Member

Just to be sure this must be merge after the feature branch was merged right?

@Wadjetz Wadjetz force-pushed the features/train-schedule-exceptions branch from 1b7c7c6 to 6f414f5 Compare April 17, 2026 07:55
@Wadjetz
Copy link
Copy Markdown
Member

Wadjetz commented Apr 17, 2026

Just to be sure this must be merge after the feature branch was merged right?

It can be merge to the feature branch too

@Wadjetz Wadjetz force-pushed the yci/removeExceptionKey branch from 80fb1b8 to 85225b2 Compare April 17, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:api-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants